activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #949: ARTEMIS-910 Broker does not start if pat...
Date Sun, 08 Jan 2017 00:32:24 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/949#discussion_r95068909
  
    --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis.cmd
---
    @@ -58,9 +58,9 @@ call %ARTEMIS_INSTANCE%\etc\artemis.profile.cmd %*
     rem "Create full JVM Args"
     set JVM_ARGS=%JAVA_ARGS%
     if not "%ARTEMIS_CLUSTER_PROPS%"=="" set JVM_ARGS=%JVM_ARGS% %ARTEMIS_CLUSTER_PROPS%
    -set JVM_ARGS=%JVM_ARGS% -classpath %ARTEMIS_HOME%\lib\artemis-boot.jar
    -set JVM_ARGS=%JVM_ARGS% -Dartemis.home=%ARTEMIS_HOME%
    -set JVM_ARGS=%JVM_ARGS% -Dartemis.instance=%ARTEMIS_INSTANCE%
    +set JVM_ARGS=%JVM_ARGS% -classpath "%ARTEMIS_HOME%\lib\artemis-boot.jar"
    --- End diff --
    
    did you actually test it on windows?
    
    
    I over tested this on both linux, windows... there's a test under ./scripts validating
it.. what is not working?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message