activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #907: ARTEMIS-883 Fix OpenWire ProducerFlowCon...
Date Wed, 21 Dec 2016 15:55:43 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/907#discussion_r93464460
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/BasicOpenWireTest.java
---
    @@ -64,6 +64,9 @@
        @Before
        public void setUp() throws Exception {
           super.setUp();
    +      System.setProperty("org.apache.activemq.transport.AbstractInactivityMonitor.keepAliveTime",
"5");
    --- End diff --
    
    shouldn't you remove this property on tearDown?
    
    What if another test is expecting this property differently? even if it's not the case
now, I think you should clear it on tearDown.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message