activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #924: ARTEMIS-878: Fixed Boolean deleteOnNoCon...
Date Thu, 15 Dec 2016 17:56:17 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/924#discussion_r92663530
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/UpdateQueue.java
---
    @@ -31,7 +31,7 @@
        String name;
     
        @Option(name = "--deleteOnNoConsumers", description = "whether to delete when it's
last consumers disconnects)")
    -   Boolean deleteOnNoConsumers = null;
    +   String deleteOnNoConsumers = null;
    --- End diff --
    
    I understand...
    It is a personal taste, but it is not counterintuitive to have 2 different (and long)
properties to be remembered instead of the same?
    In addition, consider for example a case in which there is already a 'no' prefix on a
property name; the negation of it will risk (depends) to become something like --noNoXXX.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message