activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From franz1981 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #924: ARTEMIS-878: Fixed Boolean deleteOnNoCon...
Date Thu, 15 Dec 2016 17:16:56 GMT
Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/924#discussion_r92655684
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/UpdateQueue.java
---
    @@ -31,7 +31,7 @@
        String name;
     
        @Option(name = "--deleteOnNoConsumers", description = "whether to delete when it's
last consumers disconnects)")
    -   Boolean deleteOnNoConsumers = null;
    +   String deleteOnNoConsumers = null;
    --- End diff --
    
    I need a parameter with 3 possible values:
    - null: no update to the queue property will happen
    - true: the queue property will be updated using a value of true
    - false: the queue property will be updated using a value of false
    
    I know that is something different, but it's a different use case..
    
    In the original version of UpdateQueue I've declared it as Boolean, but after creating
a queue with 
    deleteOnNoConsumers=true there are no ways to use an UpdateQueue command to turn deleteOnNoConsumers
to false.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message