activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #924: ARTEMIS-878: Fixed Boolean deleteOnNoCon...
Date Thu, 15 Dec 2016 16:48:50 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/924#discussion_r92649677
  
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/queue/UpdateQueue.java
---
    @@ -31,7 +31,7 @@
        String name;
     
        @Option(name = "--deleteOnNoConsumers", description = "whether to delete when it's
last consumers disconnects)")
    -   Boolean deleteOnNoConsumers = null;
    +   String deleteOnNoConsumers = null;
    --- End diff --
    
    That's wrong...
    
    Boolean arguments are just set with --deleteOnNoConsumers
    
    No arguments...
    
    By doing this you will have to specify the type... which is different from anything on
the CLi.. that's wrong..
    
    
    
    The CLI is totally broken BTW in regards to address and queues...  the errors are not
displayed correctly... most of the other CLI will use input on key elements.
    
    
    This needs to be addressed somehow.. but this PR is not consistent with the other operations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message