activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clebert Suconic <clebert.suco...@gmail.com>
Subject Re: Many old open PRs
Date Tue, 01 Nov 2016 22:06:04 GMT
+1...


But always try to ask the author to close it first (or fix it)... Just
out of politeness.

Of course I don't mean this to the current batch of PRs.. there are
too many now and it would be difficult to do this for all of them..
just for a future workflow.



On Tue, Nov 1, 2016 at 4:02 PM, Hadrian Zbarcea <hzbarcea@gmail.com> wrote:
> I had a quick chat with infra. The only two options to close a PR are "This
> closes #..." or open a ticket. I doubt a new option will be available
> anytime soon. Opening a ticket sounds a bit overkill to me.
>
> I am ok with empty "This closes #..." on master or other branch, kind of
> neutral actually, I don't think it matters that much, even master is ok. Any
> strong opinions?
>
> I would recommend a comment like: "This closes #xxx. Won't fix".
>
> Cheers,
> Hadrian
>
>
>
> On 10/24/2016 10:39 AM, Christopher Shannon wrote:
>>
>> I don't really like the idea of empty commits laying around.  It would be
>> nice if infra could give us permission somehow to actually close these
>> commits on github.
>>
>> On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic
>> <clebert.suconic@gmail.com>
>> wrote:
>>
>>> Yeah... that's what I meant by the "This closes #..."
>>>
>>> but if you are rejecting a PR, you will need the empty commit living
>>> in a branch.
>>>
>>>
>>> If we are ok with that, we can just add the empty commit.
>>>
>>> On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré <jb@nanthrax.net>
>>> wrote:
>>>>
>>>> You can also create a "fake" commit containing "This closes #...".
>>>>
>>>> No need to request infra imho.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> ⁣
>>>>
>>>> On Oct 23, 2016, 20:01, at 20:01, Clebert Suconic <
>>>
>>> clebert.suconic@gmail.com> wrote:
>>>>>
>>>>> There are ways to close a PR on Apache mirrors:
>>>>>
>>>>> - by merging the PR
>>>>> - by adding a commit saying.
>>>>>  "This closes #NR"
>>>>> - by asking infra
>>>>>
>>>>>
>>>>> If the PR is stale you will need to ask infra. As no one outside the
>>>>> Apache
>>>>> infra have auth to close the PR.
>>>>>
>>>>> On Sunday, October 23, 2016, Jean-Baptiste Onofré <jb@nanthrax.net>
>>>>> wrote:
>>>>>
>>>>>> Good idea Hadrian.
>>>>>>
>>>>>> I will try to take a look.
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>> ⁣
>>>>>>
>>>>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com
>>>>>> <javascript:;>> wrote:
>>>>>>>
>>>>>>> There are a number of old, even very old, PRs open [1]. Some
I
>>>>>
>>>>> suspect
>>>>>>>
>>>>>>> are not relevant anymore. It'd be great if somebody could look
into
>>>>>>> them
>>>>>>> and close them down. I will try to find some time next week and
help
>>>>>>> with that as well.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Hadrian
>>>>>>>
>>>>>>> [1] https://github.com/apache/activemq/pulls
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Clebert Suconic
>>>
>>>
>>>
>>>
>>> --
>>> Clebert Suconic
>>>
>>
>



-- 
Clebert Suconic

Mime
View raw message