activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #889: ARTEMIS-852: Add PK and index to create ...
Date Wed, 16 Nov 2016 14:08:31 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/889#discussion_r88242343
  
    --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/mysql/MySQLSQLProvider.java
---
    @@ -36,8 +36,10 @@ private MySQLSQLProvider(String tName) {
              "(ID INTEGER NOT NULL AUTO_INCREMENT," +
              "FILENAME VARCHAR(255), EXTENSION VARCHAR(10), DATA LONGBLOB, PRIMARY KEY(ID))
ENGINE=InnoDB;";
     
    -      createJournalTableSQL = "CREATE TABLE " + tableName +
    -         "(id BIGINT,recordType SMALLINT,compactCount SMALLINT,txId BIGINT,userRecordType
SMALLINT,variableSize INTEGER,record LONGBLOB,txDataSize INTEGER,txData LONGBLOB,txCheckNoRecords
INTEGER,seq BIGINT) ENGINE=InnoDB;";
    +      createJournalTableSQL = new String[] {
    +         "CREATE TABLE " + tableName + "(id BIGINT,recordType SMALLINT,compactCount SMALLINT,txId
BIGINT,userRecordType SMALLINT,variableSize INTEGER,record LONGBLOB,txDataSize INTEGER,txData
LONGBLOB,txCheckNoRecords INTEGER,seq BIGINT) ENGINE=InnoDB;",
    +         "CREATE INDEX " + tableName + "_IDX ON " + tableName + " (id)"
    --- End diff --
    
    great idea to use arrays


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message