activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hadrian Zbarcea <hzbar...@gmail.com>
Subject Re: Many old open PRs
Date Tue, 01 Nov 2016 12:21:39 GMT
Nah, replied to your mail because the rest of the thread went into ideas 
on how to close PRs.

I assume you have better things to do in beam-land :).

Cheers,
Hadrian


On 11/01/2016 02:12 AM, Jean-Baptiste Onofré wrote:
> Hi Hadrian,
>
> Please, let me know if you need some help there.
>
> Regards
> JB
>
> On 11/01/2016 02:12 AM, Hadrian Zbarcea wrote:
>> Started to look into old PRs, some should not be merged. I'll see if I
>> could sort it out with infra to get them closed without a commit,
>> although imho, a commit like "This closes #xxx. Intentionally not
>> merged" is better, as it would show that the close without merge was
>> intentional.
>>
>> Another issue is that the build system looks like is in need of a bit of
>> love, some outdated and inconsistent dependencies for plugins. I fixed a
>> few, a few more that need a closer attentions. I saw that cshannon
>> merged a PR, I looked at it too, but I am not sure how it was tested as
>> many test fail intermittently, some just fail and jenkins didn't have a
>> clean build in a while. I'll look into those too.
>>
>> Cheers,
>> Hadrian
>>
>> On 10/23/2016 02:11 AM, Jean-Baptiste Onofré wrote:
>>> Good idea Hadrian.
>>>
>>> I will try to take a look.
>>>
>>> Regards
>>> JB
>>>
>>> ⁣​
>>>
>>> On Oct 23, 2016, 03:48, at 03:48, Hadrian Zbarcea <hzbarcea@gmail.com>
>>> wrote:
>>>> There are a number of old, even very old, PRs open [1]. Some I suspect
>>>> are not relevant anymore. It'd be great if somebody could look into
>>>> them
>>>> and close them down. I will try to find some time next week and help
>>>> with that as well.
>>>>
>>>> Cheers,
>>>> Hadrian
>>>>
>>>> [1] https://github.com/apache/activemq/pulls
>>>
>

Mime
View raw message