Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: Quinn Stevenson <quinn@pronoia-solutions.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_D2DC996C-A567-48F9-8B66-0CF23B0869C4"
Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\))
Subject: Re: Any Interest in this PR?
Date: Tue, 4 Oct 2016 10:30:08 -0600
References: <git-pr-198-activemq@git.apache.org>
 <F00E7BD6-3CD1-4C9C-8587-D948FC39BA08@pronoia-solutions.com>
 <CACHnxzwrt=6YUCgqNjK+84EwbvRAyhXjkWCfMyGrjoC1fc54Og@mail.gmail.com>
 <CAKF+bsosQnNVKH+mCkMPnEN+F-Fwvp6d6z2KLdtnP36A-TiHaQ@mail.gmail.com>
To: dev@activemq.apache.org
In-Reply-To: <CAKF+bsosQnNVKH+mCkMPnEN+F-Fwvp6d6z2KLdtnP36A-TiHaQ@mail.gmail.com>
Message-Id: <96C0C861-9642-46B0-8FF2-5BFB731BF059@pronoia-solutions.com>
archived-at: Tue, 04 Oct 2016 16:30:18 -0000

--Apple-Mail=_D2DC996C-A567-48F9-8B66-0CF23B0869C4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Clebert -

It is very similar to what I contributed for Artemis. =20

The additions to the EmbeddedActiveMQBroker (for ActiveMQ 5.x) closely =
mirror what I included in the EmbeddedActiveMQResource and =
EmbeddedJMSResource (for Artemis). =20

The client resources are different - the client resources for ActiveMQ =
5.x are JMS only (but they should work with an Artemis JMS Server), =
while the client resources for Artemis are native (i.e. not JMS =
specific).

I=E2=80=99d like to see what you put in the Artemis documentation, but I =
don=E2=80=99t know where I can find it - my Google-foo is failing me =
:-).   Can you help me out with that?


> On Sep 30, 2016, at 5:35 AM, Clebert Suconic =
<clebert.suconic@gmail.com> wrote:
>=20
> It is the same thing you sent on Artemis. Right ?
>=20
> It's Merged there already. I even added a few extra things and docs. =
(If
> you could read the docs please)
>=20
> On Friday, September 30, 2016, Christopher Shannon <
> christopher.l.shannon@gmail.com =
<mailto:christopher.l.shannon@gmail.com>> wrote:
>=20
>> I am interested but haven't had a chance to look at it closely yet as =
it is
>> a big commit.  But I think it would be fine to be merged into 5.15 or =
even
>> 5.14.2 since it is just an improvement for the junit support.
>>=20
>> On Thu, Sep 29, 2016 at 9:52 PM, Quinn Stevenson <
>> quinn@pronoia-solutions.com <javascript:;>> wrote:
>>=20
>>> I=E2=80=99ve had this PR open for a while now, but I haven=E2=80=99t =
heard anything back.
>>>=20
>>> If the community isn=E2=80=99t interested in this PR, please let me =
know so I can
>>> close it.
>>>=20
>>>> On Sep 16, 2016, at 3:09 PM, hqstevenson <git@git.apache.org
>> <javascript:;>> wrote:
>>>>=20
>>>> GitHub user hqstevenson opened a pull request:
>>>>=20
>>>>   https://github.com/apache/activemq/pull/198
>>>>=20
>>>>   AMQ-6428 - Add methods to EmbeddedActiveMQBroker an ActiveMQ =
client
>>> JUnit Rules
>>>>=20
>>>>=20
>>>>=20
>>>> You can merge this pull request into a Git repository by running:
>>>>=20
>>>>   $ git pull https://github.com/hqstevenson/activemq AMQ-6428
>>>>=20
>>>> Alternatively you can review and apply these changes as the patch =
at:
>>>>=20
>>>>   https://github.com/apache/activemq/pull/198.patch
>>>>=20
>>>> To close this pull request, make a commit to your master/trunk =
branch
>>>> with (at least) the following in the commit message:
>>>>=20
>>>>   This closes #198
>>>>=20
>>>> ----
>>>> commit 343e3738b5cffdd6b95cfa257134108105f714c7
>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com =
<javascript:;>>
>>>> Date:   2016-09-16T20:59:13Z
>>>>=20
>>>>   Added methods to EmbeddedActiveMQBroker to send messages, as well =
as
>>> JUnit Rules for ActiveMQ clients
>>>>=20
>>>> commit f7b5b901004b90975cb82390684e89df57eaced4
>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com =
<javascript:;>>
>>>> Date:   2016-09-16T20:59:47Z
>>>>=20
>>>>   Merge branch 'master' of https://git-wip-us.apache.org/
>>> repos/asf/activemq into AMQ-6428
>>>>=20
>>>> commit 7be356017eecf37fa9c4884906e4eda06d8a6f19
>>>> Author: Quinn Stevenson <quinn@pronoia-solutions.com =
<javascript:;>>
>>>> Date:   2016-09-16T21:07:13Z
>>>>=20
>>>>   Added license header to files
>>>>=20
>>>> ----
>>>>=20
>>>>=20
>>>> ---
>>>> If your project is set up for it, you can reply to this email and =
have
>>> your
>>>> reply appear on GitHub as well. If your project does not have this
>>> feature
>>>> enabled and wishes so, or if the feature is enabled but not =
working,
>>> please
>>>> contact infrastructure at infrastructure@apache.org <javascript:;> =
or
>> file a JIRA
>>> ticket
>>>> with INFRA.
>>>> ---
>>>=20
>>>=20
>>=20
>=20
>=20
> --=20
> Clebert Suconic


--Apple-Mail=_D2DC996C-A567-48F9-8B66-0CF23B0869C4--