activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John D. Ament" <johndam...@apache.org>
Subject Re: Many old open PRs
Date Fri, 28 Oct 2016 20:50:37 GMT
Interesting, that used to work at least.  I wonder if github has changed
something recently.

John

On Fri, Oct 28, 2016 at 4:46 PM Clebert Suconic <clebert.suconic@gmail.com>
wrote:

> https://github.com/apache/activemq-artemis/pull/873
>
> ^^ didn't work
>
> On Fri, Oct 28, 2016 at 4:46 PM, Clebert Suconic
> <clebert.suconic@gmail.com> wrote:
> > I just tried the tmp branch approach and it didn't work:
> >
> > I guess it must be on master, otherwise the apache bot won't see it.
> > Unless we ask Infra to tweak the bot.
> >
> > On Tue, Oct 25, 2016 at 6:22 AM, Christopher Shannon
> > <christopher.l.shannon@gmail.com> wrote:
> >> +1 for using a temporary branch and then deleting it after the PR is
> >> closed.  That way there's no empty commits laying around.
> >>
> >> On Mon, Oct 24, 2016 at 5:15 PM, Clebert Suconic <
> clebert.suconic@gmail.com>
> >> wrote:
> >>
> >>> On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament <johndament@apache.org>
> >>> wrote:
> >>> > You can also push up the commits to a separate branch, which closes
> the
> >>> PR,
> >>> > then delete that branch (note you have to eventually push a real
> commit
> >>> on
> >>> > top so there will be a short delay until someone commits to git in
a
> >>> > non-delete fashion).
> >>> >
> >>>
> >>> Ahhhhh.... a temporary branch... hmmmm
> >>>
> >>> We can push -f :temporary-branch when it's closed.
> >>>
> >>>
> >>> That works
> >>>
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message