activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #872: A few fixes before the release around jo...
Date Mon, 31 Oct 2016 19:11:54 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/872#discussion_r85811440
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/OrderedExecutorFactory.java
---
    @@ -104,7 +103,7 @@ public void run() {
                             // This could happen during shutdowns. Nothing to be concerned
about here
                             logger.debug("Interrupted Thread", e);
                          } catch (Throwable t) {
    -                        ActiveMQClientLogger.LOGGER.caughtunexpectedThrowable(t);
    +                        logger.warn(t.getMessage(), t);
    --- End diff --
    
    nope... it's just a generic exception, it can just call logger.warn directly
    if were doing anything with it, such as adding our messages.. then it would be through
the internationalized Logger.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message