activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bennetelli <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #873: ARTEMIS-830 Remove cyclic dependencies f...
Date Sat, 29 Oct 2016 15:03:42 GMT
GitHub user bennetelli reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/873

    ARTEMIS-830 Remove cyclic dependencies from artemis-jdbc-store

    Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct
by moving classes and methods to other locations and reducing the visibility of classes, fields
and methods. Solving cyclic dependencies is important to keep the codebase maintainable. Scenarios
where "everything uses everything" should be avoided.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bennetelli/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #873
    
----
commit 1d22953bc17815df1716fe79d48497cb180afaf8
Author: Bennet Schulz <mail@bennet-schulz.de>
Date:   2016-10-28T11:46:00Z

    ARTEMIS-830 Remove cyclic dependencies
    
    Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct
by moving classes and methods to other locations and reducing the visibility of classes, fields
and methods. Solving cyclic dependencies is important to keep the codebase maintainable. Scenarios
where "everything uses everything" should be avoided.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message