activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #866: couple of AMQP fixes
Date Wed, 26 Oct 2016 17:36:45 GMT
Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/866#discussion_r85177941
  
    --- Diff: tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpSender.java
---
    @@ -71,6 +71,7 @@
     
        private final Set<Delivery> pending = new LinkedHashSet<>();
        private byte[] encodeBuffer = new byte[1024 * 8];
    +   DeliveryUpdateListener deliveryUpdateListener;
    --- End diff --
    
    I think it might make more sense to extend the validator bits already in the client to
add event points for Delivery and Delivery update vs adding yet another callback mechanism.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message