activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cshannon <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...
Date Mon, 24 Oct 2016 19:06:11 GMT
Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/864#discussion_r84760382
  
    --- Diff: pom.xml ---
    @@ -128,8 +128,8 @@
           <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
           <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     
    -      <maven.compiler.source>1.7</maven.compiler.source>
    -      <maven.compiler.target>1.7</maven.compiler.target>
    +      <maven.compiler.source>1.8</maven.compiler.source>
    --- End diff --
    
    I am fine with either, I just pushed the PR against master but if we want to do 1.6 we
can wait to merge it until after 1.5 is released.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message