activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #852: ARTEMIS-811 Broker sends unsolicited Det...
Date Thu, 20 Oct 2016 21:36:07 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/852#discussion_r84380907
  
    --- Diff: tests/artemis-test-support/src/main/java/org/apache/activemq/transport/amqp/client/AmqpClient.java
---
    @@ -76,6 +77,23 @@ public AmqpConnection connect() throws Exception {
        }
     
        /**
    +    * Creates a connection with the broker at the given location, this method initiates
a
    +    * connect attempt immediately and will fail if the remote peer cannot be reached.
    +    *
    +    * @param  protocolTracer handler of all the received and sent frames
    +    * @throws Exception if an error occurs attempting to connect to the Broker.
    +    * @return a new connection object used to interact with the connected peer.
    +    */
    +   public AmqpConnection connect(final ProtocolTracer protocolTracer) throws Exception
{
    --- End diff --
    
    @tabish121  wouldn't this needed to by sync with AMQ5 code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message