activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TomasHofman <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...
Date Wed, 19 Oct 2016 12:21:49 GMT
Github user TomasHofman commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/849#discussion_r84056887
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
    @@ -290,9 +292,19 @@ public int getServerVersion() {
     
        @Override
        public ClientSession.AddressQuery addressQuery(final SimpleString address) throws
ActiveMQException {
    -      SessionBindingQueryResponseMessage_V3 response = (SessionBindingQueryResponseMessage_V3)
sessionChannel.sendBlocking(new SessionBindingQueryMessage(address), PacketImpl.SESS_BINDINGQUERY_RESP_V3);
    -
    -      return new AddressQueryImpl(response.isExists(), response.getQueueNames(), response.isAutoCreateJmsQueues(),
response.isAutoCreateJmsTopics());
    +      if (sessionChannel.supports(PacketImpl.SESS_BINDINGQUERY_RESP_V3)) {
    --- End diff --
    
    I checked and failing tests are passing on my local machine when using original commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message