activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...
Date Tue, 18 Oct 2016 18:29:57 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/839#discussion_r83920218
  
    --- Diff: artemis-server-osgi/src/main/java/org/apache/activemq/artemis/osgi/ProtocolTrackerCallBack.java
---
    @@ -25,4 +25,6 @@
        void addFactory(ProtocolManagerFactory<Interceptor> pmf);
     
        void removeFactory(ProtocolManagerFactory<Interceptor> pmf);
    +
    +   void setDataSourceDependency(boolean dataSourceDependency);
    --- End diff --
    
    what about renaming this to:
    
    addDataSource(WhateverInformationForTheDatasource);
    
    
    the callback could then decide what to do.
    
    
    the best would be to have a class extending ProtocolTrackerCallback:
    
    
    ServerTrackerCallback extends ProtocolTrackerCallback
    
    
    And at the caller we would check an instanceof.
    
    Would that be possible with OSGI?
    
    
    
    BTW: thanks for rebasing... at least I can comment on these changes now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message