activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration
Date Tue, 18 Oct 2016 02:21:36 GMT
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/839
  
    There is one change that is wrong here. You are using the ProtocolTrackerCallback to admin
DataSources. Can you separate this into a separate class? DataSourceTrackerCallback?
    
    And instead of returning a true or false, can you return the name of the datasources?
    
    
    
    Also: I coudln't comment on the change here given the merge mess you have on this branch
now. Can  you execute these commands please?
    
    
    
    ```
    git pull --rebase upstream master
    git push origin -f your-branch-name
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message