Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: clebertsuconic <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-787-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-787-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...
Content-Type: text/plain
Message-Id: <20160921202816.1B9E6DFBBB@git1-us-west.apache.org>
Date: Wed, 21 Sep 2016 20:28:15 +0000 (UTC)
archived-at: Wed, 21 Sep 2016 20:28:18 -0000

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/787#discussion_r79924952
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java ---
    @@ -0,0 +1,242 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.server;
    +
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.core.filter.Filter;
    +import org.apache.activemq.artemis.core.filter.FilterUtils;
    +import org.apache.activemq.artemis.core.paging.PagingManager;
    +import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
    +
    +public final class QueueConfig {
    +
    +   private final long id;
    +   private final SimpleString address;
    +   private final SimpleString name;
    +   private final Filter filter;
    +   private final PageSubscription pageSubscription;
    +   private final SimpleString user;
    +   private final boolean durable;
    +   private final boolean temporary;
    +   private final boolean autoCreated;
    +
    +   public static final class Builder {
    +
    +      private final long id;
    +      private final SimpleString address;
    +      private final SimpleString name;
    +      private Filter filter;
    +      private PagingManager pagingManager;
    +      private SimpleString user;
    +      private boolean durable;
    +      private boolean temporary;
    +      private boolean autoCreated;
    +
    +      private Builder(final long id, final SimpleString name) {
    +         this(id, name, name);
    +      }
    +
    +      private Builder(final long id, final SimpleString name, final SimpleString address) {
    +         //TODO Checks if what are valid default values and/or enforces not mandatory fields to be on Builder's constructor
    +         this.id = id;
    +         this.name = name;
    +         this.address = address;
    +         this.filter = null;
    +         this.pagingManager = null;
    +         this.user = null;
    +         this.durable = true;
    +         this.temporary = false;
    +         this.autoCreated = true;
    +         validateState();
    +      }
    +
    +      //TODO maybe an SimpleString::isEmpty method would be welcome
    --- End diff --
    
    I would remove this TODO as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---