Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: mtaylor <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-749-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-749-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #749: ARTEMIS-581 Implement max disk usage, an...
Content-Type: text/plain
Message-Id: <20160905134829.22FC8DFDD3@git1-us-west.apache.org>
Date: Mon,  5 Sep 2016 13:48:29 +0000 (UTC)
archived-at: Mon, 05 Sep 2016 13:48:31 -0000

Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/749#discussion_r77524578
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java ---
    @@ -1249,6 +1256,14 @@ public RoutingStatus send(final ServerMessage message, final boolean direct) thr
     
        @Override
        public RoutingStatus send(final ServerMessage message, final boolean direct, boolean noAutoCreateQueue) throws Exception {
    +
    +      // If the protocol doesn't support flow control, we have no choice other than fail the communication
    +      if (!this.getRemotingConnection().isSupportsFlowControl() && pagingManager.isDiskFull()) {
    +         ActiveMQIOErrorException exception = ActiveMQMessageBundle.BUNDLE.diskBeyondLimit();
    +         this.getRemotingConnection().fail(exception);
    +         throw exception;
    --- End diff --
    
    Also even with flow control switched on, the client is still able to send until it's current credit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---