activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scop <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #804: Update error prone, flag missing @Overri...
Date Tue, 27 Sep 2016 11:45:03 GMT
GitHub user scop opened a pull request:

    https://github.com/apache/activemq-artemis/pull/804

    Update error prone, flag missing @Override as error

    This updates error prone to 2.0.9. It is not the latest version at the moment (2.0.13
is), but later versions than that introduce new errors that are unrelated to the missing Overrides
I'm doing this for, so I suggest tackling them separately sometime. The `Condition.await`
WaitNotInLoop fixes are necessary, can't have a new enough error prone without them (or without
dialing WaitNotInLoop back from error). Review for these appreciated.
    
    artemis-selectors' generated code doesn't pass the missing overrides check, so for the
moment this downgrades that check to warnings for the submodule. I don't know if this could
be done only for the `generated-sources` dir therein.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scop/activemq-artemis error-prone

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #804
    
----
commit 75b52169f82b95e2a20205f3ed1a8f1da7b7aeb4
Author: Ville Skyttä <ville.skytta@iki.fi>
Date:   2016-09-27T10:49:21Z

    Update javac-errorprone to 2.8 and error_prone_core to 2.0.9

commit 1a4fe928022eac30ef03de94f24902d0d5c20f92
Author: Ville Skyttä <ville.skytta@iki.fi>
Date:   2016-09-27T11:28:29Z

    Fix WaitNotInLoop issues flagged by new Error Prone

commit 78d8ddffbee99d316392864547d41a074d3b869a
Author: Ville Skyttä <ville.skytta@iki.fi>
Date:   2016-09-27T11:36:00Z

    Flag missing @Override as error in Error Prone

commit 447d7840aa9f8fe81eec36e88cd1360b5b573401
Author: Ville Skyttä <ville.skytta@iki.fi>
Date:   2016-09-27T11:36:54Z

    Add missing @Overrides

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message