activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tabish121 <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...
Date Fri, 30 Sep 2016 15:01:15 GMT
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/814
  
    The tests seem to be using sleep calls to determine connection closed which is not the
best given that it might close long before, or not depending on the speed of the machine,
I'd recommend using the Wait class that was pulled over from 5.x where you can do a "Wait.waitFor(new
Wait.Condition() { return ....} );"  that way you can avoid adding a bunch of extra time to
the tests unnecessarily 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message