activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...
Date Wed, 21 Sep 2016 15:23:01 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/787#discussion_r79860213
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
    @@ -1290,10 +1291,7 @@ protected ServerSessionImpl internalCreateSession(String name,
                                                          SessionCallback callback,
                                                          OperationContext context,
                                                          boolean autoCreateJMSQueues) throws
Exception {
    -      return new ServerSessionImpl(name, username, password, validatedUser, minLargeMessageSize,
autoCommitSends, autoCommitAcks, preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(),
    -                                   xa, connection, storageManager, postOffice, resourceManager,
securityStore, managementService, this, configuration.getManagementAddress(),
    -                                   defaultAddress == null ? null : new SimpleString(defaultAddress),
callback, context, autoCreateJMSQueues ? jmsQueueCreator : null,
    -                                   pagingManager);
    +      return new ServerSessionImpl(name, username, password, validatedUser, minLargeMessageSize,
autoCommitSends, autoCommitAcks, preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(),
xa, connection, storageManager, postOffice, resourceManager, securityStore, managementService,
this, configuration.getManagementAddress(), defaultAddress == null ? null : new SimpleString(defaultAddress),
callback, context, autoCreateJMSQueues ? jmsQueueCreator : null, pagingManager);
    --- End diff --
    
    this line gets too big.. can you break it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message