activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #749: ARTEMIS-581 Implement max disk usage, an...
Date Mon, 05 Sep 2016 13:35:11 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/749#discussion_r77522847
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
    @@ -429,6 +429,12 @@ public static String getDefaultHapolicyBackupStrategy() {
        // Default period to wait between configuration file checks
        public static final long DEFAULT_CONFIGURATION_FILE_REFRESH_PERIOD = 5000;
     
    +   public static final long DEFAULT_GLOBAL_MAX_SIZE = -1;
    --- End diff --
    
    USAGE implies %, and it would be confusing with the other parameter.
    
    AddressSize's counterpart of this is called getMaxSizeBytes. I could call rename them
all to maxSizeBytes. (I was happy with just max_size though :) )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message