Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EE48D200B6F for ; Wed, 24 Aug 2016 13:42:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ECE57160AB1; Wed, 24 Aug 2016 11:42:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36E26160AA4 for ; Wed, 24 Aug 2016 13:42:54 +0200 (CEST) Received: (qmail 62757 invoked by uid 500); 24 Aug 2016 11:42:53 -0000 Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list dev@activemq.apache.org Received: (qmail 62742 invoked by uid 99); 24 Aug 2016 11:42:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2016 11:42:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 73D3DE03C0; Wed, 24 Aug 2016 11:42:52 +0000 (UTC) From: lulf To: dev@activemq.apache.org Reply-To: dev@activemq.apache.org References: In-Reply-To: Subject: [GitHub] activemq-artemis pull request #726: Don't send jgroup messages to self Content-Type: text/plain Message-Id: <20160824114252.73D3DE03C0@git1-us-west.apache.org> Date: Wed, 24 Aug 2016 11:42:52 +0000 (UTC) archived-at: Wed, 24 Aug 2016 11:42:55 -0000 Github user lulf commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/726#discussion_r76041070 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/jgroups/JChannelManager.java --- @@ -34,7 +34,7 @@ private static final Logger logger = Logger.getLogger(JChannelManager.class); - private Map channels; --- End diff -- @clebertsuconic The ChannelBroadcastEndpointFactory is not used in my code path. Instead, the JGroupsFileBroadcastEndpointFactory is used, see FileConfigurationParser line 1218 and 1251. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---