Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: johnament <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-712-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-712-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #712: Artemis 447
Content-Type: text/plain
Message-Id: <20160810125800.0E0D4DFE2E@git1-us-west.apache.org>
Date: Wed, 10 Aug 2016 12:58:00 +0000 (UTC)
archived-at: Wed, 10 Aug 2016 12:58:02 -0000

Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/712#discussion_r74238129
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/proton/ProtonTest.java ---
    @@ -211,6 +213,25 @@ public void testBrokerContainerId() throws Exception {
        }
     
        @Test
    +   public void testBrokerConnectionProperties() throws Exception {
    +      if (protocol != 0 && protocol != 3) return; // Only run this test for AMQP protocol
    --- End diff --
    
    Can this be an assume statement (this way the test will be marked as skipped if this is not true)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---