activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lulf <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #726: Ignore jgroup messages coming from itsel...
Date Thu, 18 Aug 2016 13:54:54 GMT
GitHub user lulf opened a pull request:

    https://github.com/apache/activemq-artemis/pull/726

    Ignore jgroup messages coming from itself

    In our broker.xml we have a broadcast group, a discovery group and a core bridge referring
to the discovery group to discover other brokers. It appears, however, that the discovery
mechanism discovers itself even when only 1 broker is running.
    
    In DiscoveryGroup.java, it compares the node id of the broadcaster with the node id of
the discoverygroup, but these id's appears to be generated randomly for both the broadcast
and discovery group. The proper fix might be to ensure that the node id is the same for both
of these, but I am not sure if it is intentional that they don't have the same id or not.
    
    This PR is an attempted fix of an issue at the jgroups level, by ignoring jgroups messages
coming from oneself. Feel free to close the PR if this should be fixed elsewhere.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lulf/activemq-artemis lulf/ignore-jgroups-payload-if-self

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #726
    
----
commit 92713b77cb410a69577f860d0ef5405b73c213ed
Author: Ulf Lilleengen <lulf@redhat.com>
Date:   2016-08-18T13:46:09Z

    Ignore jgroup messages coming from itself

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message