activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker
Date Wed, 31 Aug 2016 14:15:53 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/740#discussion_r76995434
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
    @@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws Exception {
           }
        }
     
    +   public void setConnectionEntry(ConnectionEntry connectionEntry) {
    +      this.connectionEntry = connectionEntry;
    +   }
    +
    +   public void setUpTtl(final long inactivityDuration, final long inactivityDurationInitialDelay,
final boolean useKeepAlive) {
    +      this.useKeepAlive = useKeepAlive;
    +      this.maxInactivityDuration = inactivityDuration;
    +
    +      protocolManager.getScheduledPool().schedule(new Runnable() {
    --- End diff --
    
    Actually.. scratch what I said before..  I thought the incoming pings were being duplicated.
    
    
    The only issues I see now are:
    
    i - nothing is cancelling the scheduler.
    
    ii - you should call checkInactivity within the Runnable on the scheduler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message