activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gaohoward <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker
Date Wed, 31 Aug 2016 02:03:58 GMT
Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/740#discussion_r76913484
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
    @@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
        }
     
        @Override
    -   public boolean checkDataReceived() {
    -      boolean res = dataReceived;
    -
    -      dataReceived = false;
    -
    -      return res;
    +   public void flush() {
    +      checkInactivity();
        }
     
    -   @Override
    -   public void flush() {
    +   private void checkInactivity() {
    +      if (!this.useKeepAlive) {
    --- End diff --
    
    But this method already in the super class, here is just a duplicate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message