activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker
Date Tue, 30 Aug 2016 14:10:53 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/740#discussion_r76802109
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
---
    @@ -508,6 +524,9 @@ public WireFormat getMarshaller() {
        }
     
        private void shutdown(boolean fail) {
    +
    +      this.ttlLatch.countDown();
    --- End diff --
    
    If you didn't use a thread you wouldn't need this.
    
    just use the scheduled executor to send pings to the client please.
    
    Cancel the executor from a future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message