activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #725: Add forceShutdown core management operat...
Date Wed, 17 Aug 2016 20:27:46 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/725#discussion_r75200266
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
    @@ -1983,6 +1983,12 @@ public void forceFailover() throws Exception {
        }
     
        @Override
    +   public void forceShutdown() throws Exception {
    +      forceFailover();
    +      System.exit(0);
    --- End diff --
    
    I'm not sure this operation is safe. It could be useful to destroy a server. Especially
when you have embedded systems through Karaf, wildfly and others... 
    
    I -1 for this feature
    
    
    
    If shutdown the Artemis server is preventing the shutdown than it's a bug, but I don't
think that's a case. If you see a case where the VM won't shutdown after a server.stop() then
it's an issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message