activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bennetelli <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #718: just some refactorings
Date Sun, 14 Aug 2016 07:37:12 GMT
Github user bennetelli commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/718#discussion_r74697287
  
    --- Diff: integration/activemq-vertx-integration/src/main/java/org/apache/activemq/artemis/integration/vertx/ActiveMQVertxLogger.java
---
    @@ -38,7 +38,7 @@
      * so an INFO message would be 191000 to 191999
      */
     @MessageLogger(projectCode = "AMQ")
    -public interface ActiveMQVertxLogger extends BasicLogger {
    +interface ActiveMQVertxLogger extends BasicLogger {
    --- End diff --
    
    This would result in making everything public, because anyone perhaps could us it in future.
    IMO it should be the other way around. Keep it as private as possible and widen access
if needed.
    
    Just say if you want to have it public or not. Will change it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message