activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bennetelli <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #718: just some refactorings
Date Fri, 12 Aug 2016 16:48:26 GMT
Github user bennetelli commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/718#discussion_r74622899
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java
---
    @@ -792,4 +737,36 @@ public void tearDown() throws Exception {
           Thread.currentThread().setContextClassLoader(contextClassLoader);
           super.tearDown();
        }
    +
    +   private CoreQueueConfiguration createCoreQueueConfiguration(String queueName) {
    +      return new CoreQueueConfiguration().setAddress(queueName).setName(queueName);
    +   }
    +
    +   private ConnectorServiceConfiguration createOutgoingConnectorServiceConfiguration(HashMap<String,
Object> config,
    +                                                                                    
String name) {
    +      return new ConnectorServiceConfiguration().setFactoryClassName(VertxOutgoingConnectorServiceFactory.class.getName()).setParams(config).setName(name);
    +   }
    +
    +   private ConnectorServiceConfiguration createIncomingConnectorServiceConfiguration(HashMap<String,
Object> config,
    +                                                                                    
String name) {
    +      return new ConnectorServiceConfiguration().setFactoryClassName(VertxIncomingConnectorServiceFactory.class.getName()).setParams(config).setName(name);
    +   }
    +
    +   private HashMap<String, Object> createIncomingConnectionConfig(String vertxAddress,
String incomingQueue) {
    +      HashMap<String, Object> config1 = new HashMap<>();
    +      config1.put(VertxConstants.HOST, host);
    +      config1.put(VertxConstants.PORT, port);
    +      config1.put(VertxConstants.VERTX_ADDRESS, vertxAddress);
    +      config1.put(VertxConstants.QUEUE_NAME, incomingQueue);
    +      return config1;
    +   }
    +
    +   private HashMap<String, Object> createOutgoingConnectionConfig(String queueName,
String vertxAddress) {
    --- End diff --
    
    Which modules? Do you mean URIs instead of VertxConstants and the config HashMap?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message