activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bennetelli <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #718: just some refactorings
Date Fri, 12 Aug 2016 16:45:17 GMT
Github user bennetelli commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/718#discussion_r74622451
  
    --- Diff: integration/activemq-vertx-integration/src/main/java/org/apache/activemq/artemis/integration/vertx/ActiveMQVertxLogger.java
---
    @@ -38,7 +38,7 @@
      * so an INFO message would be 191000 to 191999
      */
     @MessageLogger(projectCode = "AMQ")
    -public interface ActiveMQVertxLogger extends BasicLogger {
    +interface ActiveMQVertxLogger extends BasicLogger {
    --- End diff --
    
    Because I don't want that anyone else ever is able to use this logger in other packages/tests.
Currently it is used within the Vert.x package only and in my opinion it should stay that
modular.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message