activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis issue #718: just some refactorings
Date Thu, 11 Aug 2016 20:28:37 GMT
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/718
  
    Can you squash those commits together so there's not a commit making the change and another
commit undoing it?  That's a bit messy.
    
    Also, your commit messages should follow the 50/72 format as outlined in the [Hacking
Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#typical-development-cycle).
 It should also reference the JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message