activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #718: just some refactorings
Date Thu, 11 Aug 2016 20:03:40 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/718#discussion_r74492945
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/vertx/ActiveMQVertxUnitTest.java
---
    @@ -282,19 +280,7 @@ public void testIncomingEvents() throws Exception {
           assertEquals(aShort, recvShort);
     
           //send a JsonObject
    -      String jsonObjectString = "{\n" +
    -         "\"Image\": {\n" +
    -         "\"Width\":  800,\n" +
    -         "\"Height\": 600,\n" +
    -         "\"Title\":  \"View from 15th Floor\",\n" +
    -         "\"Thumbnail\": {\n" +
    -         "\"Url\":    \"http://www.example.com/image/481989943\",\n" +
    -         "\"Height\": 125,\n" +
    -         "\"Width\":  100\n" +
    -         "},\n" +
    -         "\"IDs\": [116, 943, 234, 38793]\n" +
    -         "}\n" +
    -         "}";
    +      String jsonObjectString = "{\n" + "\"Image\": {\n" + "\"Width\":  800,\n" + "\"Height\":
600,\n" + "\"Title\":  \"View from 15th Floor\",\n" + "\"Thumbnail\": {\n" + "\"Url\":   
\"http://www.example.com/image/481989943\",\n" + "\"Height\": 125,\n" + "\"Width\":  100\n"
+ "},\n" + "\"IDs\": [116, 943, 234, 38793]\n" + "}\n" + "}";
    --- End diff --
    
    In my opinion, unwrapping these lines (and other like this) makes it harder to read/change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message