activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #691: ARTEMIS-659 Remove unneeded CDI dependen...
Date Mon, 01 Aug 2016 19:11:15 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/691#discussion_r73035248
  
    --- Diff: pom.xml ---
    @@ -349,16 +349,9 @@
     
              <!-- Required for: JMS Injection -->
              <dependency>
    -            <groupId>javax.enterprise</groupId>
    -            <artifactId>cdi-api</artifactId>
    -            <version>1.2</version>
    -            <!-- License: Apache 2.0 -->
    -         </dependency>
    -         <dependency>
    -            <groupId>javax.inject</groupId>
    -            <artifactId>javax.inject</artifactId>
    -            <version>1</version>
    -            <!-- License: Apache 2.0 -->
    +            <groupId>org.apache.geronimo.specs</groupId>
    +            <artifactId>geronimo-atinject_1.0_spec</artifactId>
    +            <version>1.0</version>
    --- End diff --
    
    JMS 2 defines injection points.  The way it ended up being phrased, its the app server's
realm of responsibility to provide those injection points.  OpenMQ for example provides a
CDI module.  HornetQ/Artemis do not as of now.  Wildfly's JMS integration module takes care
of this, similarly TomEE does the same.
    
    It turns out this is needed for the link you emailed earlier - the integration test for
Karaf/OSGi.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message