activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...
Date Mon, 01 Aug 2016 11:48:35 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/672#discussion_r72964880
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java
---
    @@ -387,4 +388,15 @@ public void setClientID(String cID) {
        public String getClientID() {
           return clientID;
        }
    +
    +   @Override
    +   public void killMessage(SimpleString nodeID) throws Exception {
    +      if (clientVersion < DisconnectConsumerWithKillMessage.VERSION_INTRODUCED) {
    +         throw new Exception(String.valueOf(clientVersion));
    --- End diff --
    
    Can this be a more specific ActiveMQ Exception?  Even if its just `ActiveMQException`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message