activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...
Date Mon, 01 Aug 2016 11:47:43 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/672#discussion_r72964784
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
    @@ -162,6 +164,14 @@ public int getReconnectID() {
           return sessionChannel.getReconnectID();
        }
     
    +   public boolean isKilled() {
    +      return killed;
    +   }
    +
    +   public void kill(boolean killed) {
    --- End diff --
    
    Sorry, I wasn't clear.  When I mentioned `kill()` I was thinking:
    
    ```
    public void kill() {
       this.killed = true;
    }
    ```
    
    This way the caller isn't directly modifying the variable.  But no big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message