Mailing-List: contact dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@activemq.apache.org
From: scop <git@git.apache.org>
To: dev@activemq.apache.org
Reply-To: dev@activemq.apache.org
References: <git-pr-680-activemq-artemis@git.apache.org>
In-Reply-To: <git-pr-680-activemq-artemis@git.apache.org>
Subject: [GitHub] activemq-artemis pull request #680: Null pointer/check related fixes
Content-Type: text/plain
Message-Id: <20160728202825.DDC82E0100@git1-us-west.apache.org>
Date: Thu, 28 Jul 2016 20:28:25 +0000 (UTC)
archived-at: Thu, 28 Jul 2016 20:28:27 -0000

Github user scop commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/680#discussion_r72696215
  
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java ---
    @@ -63,10 +63,15 @@ public static final boolean deleteDirectory(final File directory) {
                 attempts++;
              }
     
    -         for (String file : files) {
    -            File f = new File(directory, file);
    -            if (!deleteDirectory(f)) {
    -               logger.warn("Failed to clean up file: " + f.getAbsolutePath());
    +         if (files == null) {
    +            logger.warn("Could not list files to clean up in: " + directory.getAbsolutePath());
    --- End diff --
    
    @johnament I don't know, but FWIW the "Failed to clean up file" one that already was and still is there is not (assuming I understand what a coded log message is...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---