activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #682: Adding set -e on merge script
Date Thu, 28 Jul 2016 20:29:02 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/682#discussion_r72696319
  
    --- Diff: scripts/merge-PR.sh ---
    @@ -16,6 +16,8 @@
     # specific language governing permissions and limitations
     # under the License.
     
    +# Setting the script to fail if anything goes wrong
    +set -e
     
     # Use this to simplify the rebasing of PRs. PRs will be rebased during the merge on this
process.
     # use: ./rebase-PR <PRID> textual description
    --- End diff --
    
    line 23 (now) of your script mentions `rebase-PR`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message