activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...
Date Thu, 28 Jul 2016 19:29:49 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/672#discussion_r72686692
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
    @@ -759,6 +769,12 @@ protected void handleReceiveProducerFailCredits(SessionProducerCreditsFailMessag
           handleReceiveProducerFailCredits(message.getAddress(), message.getCredits());
        }
     
    +   protected void handleReceiveSlowConsumerKillMessage(DisconnectConsumerWithKillMessage
message) {
    +      if (message.getNodeID() != null) {
    +         setKilled(true);
    --- End diff --
    
    since its always called with true, would it make sense to have a `kill()` method instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message