activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbertram <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #677: ARTEMIS-595 additional JSON fixes
Date Thu, 28 Jul 2016 14:34:41 GMT
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/677#discussion_r72633668
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java
---
    @@ -295,6 +295,13 @@ else if (jsonValue == JsonValue.FALSE) {
                 return jsonValue.toString();
              }
           }
    +      else if (jsonValue instanceof Object[]) {
    +         Object[] array = (Object[]) jsonValue;
    +         for (int i = 0; i < array.length; i++) {
    +            array[i] = convertJsonValue(array[i], desiredType);
    --- End diff --
    
    The use case for this that I've seen are management methods that return stuff like String[].
 That said, I see your point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message