activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #672: [ARTEMIS-642] Disable slow client reconn...
Date Wed, 27 Jul 2016 11:10:11 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/672#discussion_r72420954
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
    @@ -2971,6 +2975,7 @@ public void run() {
                    else if (consumerRate < threshold) {
                       RemotingConnection connection = null;
                       RemotingService remotingService = ((PostOfficeImpl) postOffice).getServer().getRemotingService();
    +                  ActiveMQServer server = ((PostOfficeImpl) postOffice).getServer();
    --- End diff --
    
    The code now casts twice.  Should this be in the interface? Should the casting be done
once?  Can server be extracted for the line above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message