activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #662: ARTEMIS-587 add more JSON JMX mgmt metho...
Date Tue, 26 Jul 2016 02:42:12 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/662#discussion_r72180014
  
    --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSServerControlImpl.java
---
    @@ -796,20 +796,12 @@ public String listSessionsAsJSON(final String connectionID) throws
Exception {
     
           clearIO();
     
    -      JsonArrayBuilder array = Json.createArrayBuilder();
           try {
    -         List<ServerSession> sessions = server.getActiveMQServer().getSessions(connectionID);
    -         for (ServerSession sess : sessions) {
    -            JsonObjectBuilder obj = Json.createObjectBuilder()
    -                  .add("sessionID", sess.getName())
    -                  .add("creationTime", sess.getCreationTime());
    -            array.add(obj);
    -         }
    +         return server.listSessionsAsJSON(connectionID);
           }
           finally {
              blockOnIO();
           }
    -      return array.toString();
    --- End diff --
    
    Shoot, just noticed this error.  As  soon as this PR is in I'll fix the other place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message