activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtaylor <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #645: Fix scaledownhandler lookup duplicate ha...
Date Wed, 20 Jul 2016 13:22:51 GMT
Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/645#discussion_r71522585
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScaleDownHandler.java
---
    @@ -578,7 +578,7 @@ public boolean lookup(MessageReference reference) throws Exception
{
                       }
     
                       if (initialRef == null) {
    -                     lastRef = initialRef;
    +                     initialRef = lastRef;
    --- End diff --
    
    This looks like it could change behaviour and if it is indeed a bug it's obviously not
covered by our test cases.  I don't know enough about this area of the code to merge this
without spending significant time figuring out how it works.  @jbertram I believe you wrote
this.  Could you take a look and merge if you're happy?  Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message