activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #610: Artemis build enhancements
Date Tue, 05 Jul 2016 16:24:35 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/610#discussion_r69594043
  
    --- Diff: pom.xml ---
    @@ -112,8 +112,8 @@
           <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
           <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     
    -      <maven.compiler.source>1.7</maven.compiler.source>
    -      <maven.compiler.target>1.7</maven.compiler.target>
    +      <maven.compiler.source>1.8</maven.compiler.source>
    +      <maven.compiler.target>1.8</maven.compiler.target>
    --- End diff --
    
    I would just leave 1.7, until there is a good reason to be 1.8.
    
    that way we would move the codebase to 1.8 on purpose, where there is the API need.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message