activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...
Date Mon, 04 Jul 2016 02:34:27 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/617#discussion_r69403171
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt/imported/MQTTTest.java
---
    @@ -380,7 +384,8 @@ public void testMQTTPathPatterns() throws Exception {
              Message msg = connection.receive(5, TimeUnit.SECONDS);
              do {
                 assertNotNull("RETAINED null " + wildcard, msg);
    -            assertTrue("RETAINED prefix " + wildcard, new String(msg.getPayload()).startsWith(RETAINED));
    +            String msgPayload = new String(msg.getPayload());
    --- End diff --
    
    One worrisome thing.  I think there's some interdependence in these tests.  I originally
added my interceptor checks in a new test method.  When I did that, this test started failing.
 It was receiving the messages created previously.  I suspect the server isn't getting cleaned
up 100% correctly, or maybe not at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message