activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From glauciom <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #610: Artemis build enhancements
Date Sat, 02 Jul 2016 02:56:33 GMT
Github user glauciom commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/610#discussion_r69371449
  
    --- Diff: pom.xml ---
    @@ -112,8 +112,8 @@
           <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
           <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     
    -      <maven.compiler.source>1.7</maven.compiler.source>
    -      <maven.compiler.target>1.7</maven.compiler.target>
    +      <maven.compiler.source>1.8</maven.compiler.source>
    +      <maven.compiler.target>1.8</maven.compiler.target>
    --- End diff --
    
    From a *very* practical point of view, it would be a win / win thing if only the server
side inherit the 1.8 part, and client-side projects and related modules specifies the 1.7
version, overriding and pom.xml parent's definition.
    
    Sounds good? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message