activemq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clebertsuconic <...@git.apache.org>
Subject [GitHub] activemq-artemis pull request #610: Artemis build enhancements
Date Fri, 01 Jul 2016 23:23:12 GMT
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/610#discussion_r69366049
  
    --- Diff: pom.xml ---
    @@ -112,8 +112,8 @@
           <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
           <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     
    -      <maven.compiler.source>1.7</maven.compiler.source>
    -      <maven.compiler.target>1.7</maven.compiler.target>
    +      <maven.compiler.source>1.8</maven.compiler.source>
    +      <maven.compiler.target>1.8</maven.compiler.target>
    --- End diff --
    
    The doc is outdated... we had complains from users, community members at the dev, and
even peers at the company I work for. So, it was a big no from everybody!
    
    
    We could require 1.8 at the server but at the client it's a bit more complicated.
    
    I would wait a good reason to require 1.8. :) So far i don't have one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message